From 9602c32ea72b92c71f74a8b92943ed088c940297 Mon Sep 17 00:00:00 2001
From: Harald Barth <haba@kth.se>
Date: Sat, 16 Nov 2024 20:50:25 +0100
Subject: [PATCH] mDNS malloc error fix

---
 EXmDNS.cpp      | 4 ++--
 STM32lwipopts.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/EXmDNS.cpp b/EXmDNS.cpp
index 09a3391..14e824b 100644
--- a/EXmDNS.cpp
+++ b/EXmDNS.cpp
@@ -75,7 +75,7 @@ int MDNS::begin(const IPAddress& ip, char* name) {
   //  delay(100);
   
   _ipAddress = ip;
-  _name = (char *)malloc(strlen(name +2));
+  _name = (char *)malloc(strlen(name)+2);
   byte n;
   for(n = 0; n<strlen(name); n++)
     _name[n+1] = name[n];
@@ -87,7 +87,7 @@ int MDNS::begin(const IPAddress& ip, char* name) {
 
 int MDNS::addServiceRecord(const char* name, uint16_t port, MDNSServiceProtocol_t proto) {
   // we ignore proto, assume TCP
-  _serviceName = (char *)malloc(strlen(name +2));
+  _serviceName = (char *)malloc(strlen(name)+2);
   byte n;
   for(n = 0; n<strlen(name); n++)
     _serviceName[n+1] = name[n];
diff --git a/STM32lwipopts.h b/STM32lwipopts.h
index 8efc641..8347b66 100644
--- a/STM32lwipopts.h
+++ b/STM32lwipopts.h
@@ -39,9 +39,9 @@
 //#define LWIP_DEBUG                      1
 //#define TCP_DEBUG                       LWIP_DBG_ON
 
-// IMPORTANT CHANGE THE FIRST ONE
+// NOT STRICT NECESSARY ANY MORE BUT CAN BE USED TO SAVE RAM
 #undef  MEM_LIBC_MALLOC
-#define MEM_LIBC_MALLOC         1       // critical, fixes heap trashing
+#define MEM_LIBC_MALLOC         1       // use the same malloc as for everything else
 #undef  MEMP_MEM_MALLOC
 #define MEMP_MEM_MALLOC         1       // uses malloc which means no pools which means slower but not mean 32KB up front