diff --git a/DCC.cpp b/DCC.cpp index c0c01dc..248c96a 100644 --- a/DCC.cpp +++ b/DCC.cpp @@ -24,6 +24,7 @@ const byte FN_GROUP_5=0x10; void DCC::begin() { + debugMode=false; DCCWaveform::begin(); } @@ -50,7 +51,7 @@ void DCC::setThrottle2( uint16_t cab, byte speedCode) { } void DCC::setFunctionInternal(int cab, byte byte1, byte byte2) { - //DIAG(F("\nsetFunctionInternal %d %x %x"),cab,byte1,byte2); + // DIAG(F("\nsetFunctionInternal %d %x %x"),cab,byte1,byte2); byte b[4]; byte nB = 0; @@ -274,6 +275,10 @@ void DCC::forgetAllLocos() { // removes all speed reminders for (int i=0;i 6) { //ACK timeout - // DIAG(F("\nWACK fail %d\n"), resets); + if (debugMode) DIAG(F("\nWACK fail polls=%d, resets=%d, max=%dmA"), ackPollCount, resets, ackMaxCurrent); ackReceived = false; break; // move on to next prog step } - current=Hardware::getCurrentMilliamps(false); + int current=Hardware::getCurrentMilliamps(false); + if (current > ackMaxCurrent) ackMaxCurrent=current; + + ackPollCount++; + // An ACK is a pulse lasting between 4.5 and 8.5 mSecs (refer @haba) if (current>ackTriggerMilliamps) { - if (ackPulseStart==0)ackPulseStart=micros(); // leading edge of pulse detected + if (ackPulseStart==0) ackPulseStart=micros(); // leading edge of pulse detected return; } // not in pulse if (ackPulseStart==0) return; // keep waiting for leading edge - { // detected trailing edge of pulse - long pulseDuration=micros()-ackPulseStart; - if (pulseDuration>4500 && pulseDuration<8000) { + + // detected trailing edge of pulse + long pulseDuration=micros()-ackPulseStart; + + if (pulseDuration>4000 && pulseDuration<9000) { + if (debugMode) DIAG(F("\nWACK-OK polls=%d, max=%dmA, pulse=%duS"),ackPollCount, ackMaxCurrent, pulseDuration); ackReceived=true; DCCWaveform::progTrack.killRemainingRepeats(); // probably no need after 8.5ms!! break; // we have a genuine ACK result - } - } + } + if (debugMode) DIAG(F("\nWACK-bad pulse polls=%d, max=%dmA, pulse=%duS"), ackPollCount, ackMaxCurrent, pulseDuration); ackPulseStart=0; // We have detected a too-short or too-long pulse so ignore and wait for next leading edge return; // keep waiting - + } case ITC0: case ITC1: // If True Callback(0 or 1) (if prevous WACK got an ACK) if (ackReceived) { ackManagerProg = NULL; // all done now - (ackManagerCallback)(opcode==ITC0?0:1); + callback(opcode==ITC0?0:1); return; } break; @@ -513,7 +536,7 @@ void DCC::ackManagerLoop() { case ITCB: // If True callback(byte) if (ackReceived) { ackManagerProg = NULL; // all done now - (ackManagerCallback)(ackManagerByte); + callback(ackManagerByte); return; } break; @@ -521,14 +544,14 @@ void DCC::ackManagerLoop() { case NAKFAIL: // If nack callback(-1) if (!ackReceived) { ackManagerProg = NULL; // all done now - (ackManagerCallback)(-1); + callback(-1); return; } break; case FAIL: // callback(-1) ackManagerProg = NULL; - (ackManagerCallback)(-1); + callback(-1); return; case STARTMERGE: @@ -560,7 +583,7 @@ void DCC::ackManagerLoop() { case COMBINELOCOID: // ackManagerStash is cv17, ackManagerByte is CV 18 ackManagerProg=NULL; - (ackManagerCallback)( ackManagerByte + ((ackManagerStash - 192) << 8)); + callback( ackManagerByte + ((ackManagerStash - 192) << 8)); return; case ITSKIP: @@ -570,17 +593,20 @@ void DCC::ackManagerLoop() { ackManagerProg++; opcode=pgm_read_byte_near(ackManagerProg); } - // DIAG(F("\nSKIPTARGET located\n")); break; case SKIPTARGET: break; default: - // DIAG(F("!! ackOp %d FAULT!!"),opcode); + DIAG(F("!! ackOp %d FAULT!!"),opcode); ackManagerProg=NULL; - (ackManagerCallback)( -1); + callback( -1); return; } // end of switch ackManagerProg++; } } +void DCC::callback(int value) { + if (debugMode) DIAG(F("\nCallback(%d)\n"),value); + (ackManagerCallback)( value); +} diff --git a/DCC.h b/DCC.h index a920073..a74191a 100644 --- a/DCC.h +++ b/DCC.h @@ -44,6 +44,7 @@ class DCC { static void setFn( int cab, byte functionNumber, bool on); static void setAccessory(int aAdd, byte aNum, bool activate) ; static bool writeTextPacket( byte *b, int nBytes); + static void setDebug(bool on); // ACKable progtrack calls bitresults callback 0,0 or -1, cv returns value or -1 static void readCV(int cv, ACK_CALLBACK callback); @@ -75,7 +76,9 @@ private: static byte cv2(int cv); static int lookupSpeedTable(int locoId); static void issueReminders(); - + static void callback(int value); + static bool debugMode; + // ACK MANAGER static ackOp const * ackManagerProg; static byte ackManagerByte; @@ -84,6 +87,8 @@ private: static byte ackManagerStash; static bool ackReceived; static int ackTriggerMilliamps; + static int ackMaxCurrent; + static int ackPollCount; static unsigned long ackPulseStart; static ACK_CALLBACK ackManagerCallback; static void ackManagerSetup(int cv, byte bitNumOrbyteValue, ackOp const program[], ACK_CALLBACK callback); diff --git a/DCCEXParser.cpp b/DCCEXParser.cpp index d6b4468..f935c66 100644 --- a/DCCEXParser.cpp +++ b/DCCEXParser.cpp @@ -227,6 +227,11 @@ void DCCEXParser::parse(Print & stream, const byte *com) { StringFormatter::send(stream,F("\n")); return; + case 'D': // < > + DCC::setDebug(p[0]==1); + DIAG(F("\nDCC DEBUG MODE %d"),p[0]==1); + return; + default: //anything else will drop out to break;