diff --git a/DCCACK.cpp b/DCCACK.cpp index 64dafa3..7a43cd1 100644 --- a/DCCACK.cpp +++ b/DCCACK.cpp @@ -67,16 +67,24 @@ CALLBACK_STATE DCCACK::callbackState=READY; ACK_CALLBACK DCCACK::ackManagerCallback; void DCCACK::Setup(int cv, byte byteValueOrBitnum, ackOp const program[], ACK_CALLBACK callback) { + // On ESP32 the joined track is hidden from sight (it has type MAIN) + // and because of that we need first check if track was joined and + // then unjoin if necessary. This requires that the joined flag is + // cleared when the prog track is removed. ackManagerRejoin=TrackManager::isJoined(); + //DIAG(F("Joined is %d"), ackManagerRejoin); if (ackManagerRejoin) { // Change from JOIN must zero resets packet. TrackManager::setJoin(false); DCCWaveform::progTrack.clearResets(); } - progDriver=TrackManager::getProgDriver(); + //DIAG(F("Progdriver is %d"), progDriver); if (progDriver==NULL) { - TrackManager::setJoin(ackManagerRejoin); + if (ackManagerRejoin) { + DIAG(F("Joined but no Prog track")); + TrackManager::setJoin(false); + } callback(-3); // we dont have a prog track! return; } diff --git a/IODevice.h b/IODevice.h index 0ae2846..af62c6e 100644 --- a/IODevice.h +++ b/IODevice.h @@ -38,6 +38,7 @@ #include "FSH.h" #include "I2CManager.h" #include "inttypes.h" +#include "TemplateForEnums.h" typedef uint16_t VPIN; // Limit VPIN number to max 32767. Above this number, printing often gives negative values. diff --git a/MotorDriver.h b/MotorDriver.h index 07e6ce8..216af08 100644 --- a/MotorDriver.h +++ b/MotorDriver.h @@ -28,12 +28,9 @@ #include "DCCTimer.h" #include +#include "TemplateForEnums.h" // use powers of two so we can do logical and/or on the track modes in if clauses. // For example TRACK_MODE_DC_INV is (TRACK_MODE_DC|TRACK_MODIFIER_INV) -template inline T operator~ (T a) { return (T)~(int)a; } -template inline T operator| (T a, T b) { return (T)((int)a | (int)b); } -template inline T operator& (T a, T b) { return (T)((int)a & (int)b); } -template inline T operator^ (T a, T b) { return (T)((int)a ^ (int)b); } enum TRACK_MODE : byte { // main modes TRACK_MODE_NONE = 1, TRACK_MODE_MAIN = 2, TRACK_MODE_PROG = 4, diff --git a/TemplateForEnums.h b/TemplateForEnums.h new file mode 100644 index 0000000..459568d --- /dev/null +++ b/TemplateForEnums.h @@ -0,0 +1,26 @@ +/* + * © 2024, Harald Barth. All rights reserved. + * + * This file is part of DCC-EX + * + * This is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * It is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with CommandStation. If not, see . + */ +#ifndef TemplateForEnums +#define TemplateForEnums +template inline T operator~ (T a) { return (T)~(int)a; } +template inline T operator| (T a, T b) { return (T)((int)a | (int)b); } +template inline T operator& (T a, T b) { return (T)((int)a & (int)b); } +template inline T operator^ (T a, T b) { return (T)((int)a ^ (int)b); } +#endif + diff --git a/TrackManager.cpp b/TrackManager.cpp index 4960a93..4b474de 100644 --- a/TrackManager.cpp +++ b/TrackManager.cpp @@ -246,9 +246,6 @@ bool TrackManager::setTrackMode(byte trackToSet, TRACK_MODE mode, int16_t dcAddr #endif #ifndef DISABLE_PROG if (mode & TRACK_MODE_PROG) { -#else - if (false) { -#endif // only allow 1 track to be prog FOR_EACH_TRACK(t) if ( (track[t]->getMode() & TRACK_MODE_PROG) && t != trackToSet) { @@ -261,6 +258,7 @@ bool TrackManager::setTrackMode(byte trackToSet, TRACK_MODE mode, int16_t dcAddr } else { track[trackToSet]->makeProgTrack(false); // only the prog track knows it's type } +#endif // When a track is switched, we must clear any side effects of its previous // state, otherwise trains run away or just dont move. @@ -360,11 +358,24 @@ bool TrackManager::setTrackMode(byte trackToSet, TRACK_MODE mode, int16_t dcAddr applyDCSpeed(trackToSet); } +#ifdef ARDUINO_ARCH_ESP32 +#ifndef DISABLE_PROG + if (tempProgTrack == trackToSet && oldmode & TRACK_MODE_MAIN && !(mode & TRACK_MODE_PROG)) { + // If we just take away the prog track, the join should not + // be active either. So do in effect an unjoin + //DIAG(F("Unsync")); + tempProgTrack = MAX_TRACKS+1; + progTrackSyncMain=false; + if (joinRelay!=UNUSED_PIN) digitalWrite(joinRelay,LOW); + } +#endif +#endif // Turn off power if we changed the mode of this track - if (mode != oldmode) + if (mode != oldmode) { track[trackToSet]->setPower(POWERMODE::OFF); - streamTrackState(NULL,trackToSet); + } + streamTrackState(NULL,trackToSet); //DIAG(F("TrackMode=%d"),mode); return true; } diff --git a/version.h b/version.h index db69609..44a33f9 100644 --- a/version.h +++ b/version.h @@ -3,7 +3,8 @@ #include "StringFormatter.h" -#define VERSION "5.2.92" +#define VERSION "5.2.93" +// 5.2.93 - Bugfix ESP32: clear progTrackSyncMain (join flag) when prog track is removed // 5.2.92 - Bugfix: FADE power off fix, EXRAIL power diagnostic fix. // 5.2.91 - Bugfix: Neopixel I2C overlap check // 5.2.90 - Bugfix: EXRAIL EXTT_TURNTABLE() now has description as optional in line with ocumentation (also fixed DCC_TURNTABLE)