From 83af99f3bdbf4548f353579a0ea20b875ea00f55 Mon Sep 17 00:00:00 2001 From: Rex Dieter Date: Sun, 1 Jan 2017 10:08:09 -0600 Subject: [PATCH 1/8] rebuild (sip) --- qgis.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qgis.spec b/qgis.spec index 3695185..877c2ac 100644 --- a/qgis.spec +++ b/qgis.spec @@ -16,7 +16,7 @@ Name: qgis Version: 2.18.2 -Release: 1%{?dist} +Release: 2%{?dist} Summary: A user friendly Open Source Geographic Information System Group: Applications/Engineering @@ -405,6 +405,9 @@ update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || : %changelog +* Sun Jan 01 2017 Rex Dieter - 2.18.2-2 +- rebuild (sip) + * Fri Dec 16 2016 Volker Froehlich - 2.18.2-1 - New upstream release From 3b4e476f50d5c090b5f926da387a9bb1d1c1c9b9 Mon Sep 17 00:00:00 2001 From: Rex Dieter Date: Sun, 1 Jan 2017 11:29:36 -0600 Subject: [PATCH 2/8] disable PyQwt support on f26++ PyQwt currently FTBFS and has broken deps --- qgis.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qgis.spec b/qgis.spec index 877c2ac..2a9afa1 100644 --- a/qgis.spec +++ b/qgis.spec @@ -69,7 +69,7 @@ BuildRequires: postgresql-devel BuildRequires: proj-devel BuildRequires: PyQt4-devel # PyQwt doesn't support qwt6, so just turn it off for now on RHEL -%if 0%{?fedora} +%if 0%{?fedora} < 26 BuildRequires: PyQwt-devel %endif BuildRequires: python2-devel @@ -406,7 +406,7 @@ update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || : %changelog * Sun Jan 01 2017 Rex Dieter - 2.18.2-2 -- rebuild (sip) +- rebuild (sip), disable PyQwt support (f26+, for now) * Fri Dec 16 2016 Volker Froehlich - 2.18.2-1 - New upstream release From 4502f08c4b349c47d0baa3454264cf922fe595cf Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Sat, 11 Feb 2017 11:12:46 +0000 Subject: [PATCH 3/8] - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild --- qgis.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qgis.spec b/qgis.spec index 2a9afa1..c57a5e4 100644 --- a/qgis.spec +++ b/qgis.spec @@ -16,7 +16,7 @@ Name: qgis Version: 2.18.2 -Release: 2%{?dist} +Release: 3%{?dist} Summary: A user friendly Open Source Geographic Information System Group: Applications/Engineering @@ -405,6 +405,9 @@ update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || : %changelog +* Sat Feb 11 2017 Fedora Release Engineering - 2.18.2-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild + * Sun Jan 01 2017 Rex Dieter - 2.18.2-2 - rebuild (sip), disable PyQwt support (f26+, for now) From b736bd1807ec994ed18cb497e1315bb8a21f3eba Mon Sep 17 00:00:00 2001 From: Volker Froehlich Date: Tue, 14 Feb 2017 18:25:15 +0100 Subject: [PATCH 4/8] Hopefully solve build error with SIP 4.19 --- qgis-2.18.2-sip419.patch | 256 +++++++++++++++++++++++++++++++++++++++ qgis.spec | 11 +- 2 files changed, 266 insertions(+), 1 deletion(-) create mode 100644 qgis-2.18.2-sip419.patch diff --git a/qgis-2.18.2-sip419.patch b/qgis-2.18.2-sip419.patch new file mode 100644 index 0000000..5f64293 --- /dev/null +++ b/qgis-2.18.2-sip419.patch @@ -0,0 +1,256 @@ +From 718581ffb12b723f9a3c0ae01b7ec2d8aed9d4bb Mon Sep 17 00:00:00 2001 +From: "Juergen E. Fischer" +Date: Sat, 11 Feb 2017 21:02:05 +0100 +Subject: [PATCH] adapt bindings to sip 4.19 (fixes #16071) + +--- + python/analysis/analysis.sip | 1 - + python/analysis/network/networkanalysis.sip | 1 - + python/core/conversions.sip | 6 +++--- + python/core/core.sip | 1 - + python/core/qgscoordinatetransform.sip | 3 ++- + python/core/qgsfeature.sip | 2 +- + python/core/qgspallabeling.sip | 2 +- + python/core/qgsvectorlayerfeatureiterator.sip | 3 ++- + python/core/raster/qgsrasterprojector.sip | 2 +- + python/gui/editorwidgets/qgsdatetimeedit.sip | 3 ++- + python/gui/editorwidgets/qgsdoublespinbox.sip | 1 + + python/gui/editorwidgets/qgsspinbox.sip | 2 +- + python/gui/gui.sip | 1 - + python/gui/qgslonglongvalidator.sip | 4 +++- + python/server/qgswmsconfigparser.sip | 2 +- + python/server/qgswmsprojectparser.sip | 2 +- + python/server/server.sip | 1 - + 17 files changed, 19 insertions(+), 18 deletions(-) + +diff --git a/python/analysis/analysis.sip b/python/analysis/analysis.sip +index ceb5056..bd90e10 100644 +--- a/python/analysis/analysis.sip ++++ b/python/analysis/analysis.sip +@@ -1,5 +1,4 @@ + %Module(name=qgis._analysis, +- version=0, + keyword_arguments="Optional") + + %Import QtCore/QtCoremod.sip +diff --git a/python/analysis/network/networkanalysis.sip b/python/analysis/network/networkanalysis.sip +index fb446d1..d2c192b 100644 +--- a/python/analysis/network/networkanalysis.sip ++++ b/python/analysis/network/networkanalysis.sip +@@ -1,5 +1,4 @@ + %Module(name=qgis._networkanalysis, +- version=0, + keyword_arguments="Optional") + + %Import QtCore/QtCoremod.sip +diff --git a/python/core/conversions.sip b/python/core/conversions.sip +index 564d4de..f07d3ab 100644 +--- a/python/core/conversions.sip ++++ b/python/core/conversions.sip +@@ -747,7 +747,7 @@ template + + // QMap is implemented as a Python dictionary. + template +-%MappedType QMap /DocType="dict-of-qint64-TYPE"/ ++%MappedType QMap + { + %TypeHeaderCode + #include +@@ -1873,7 +1873,7 @@ template + }; + + // QList is implemented as a Python list of QgsField. +-%MappedType QList /DocType="list-of-qgsfield"/ ++%MappedType QList + { + %TypeHeaderCode + #include +@@ -1978,7 +1978,7 @@ template + + %If (QVECTORINT_CONVERSION) + // QVector is implemented as a Python list of integers. +-%MappedType QVector /DocType="list-of-int"/ ++%MappedType QVector + { + %TypeHeaderCode + #include +diff --git a/python/core/core.sip b/python/core/core.sip +index 577c4c1..8f0b6af 100644 +--- a/python/core/core.sip ++++ b/python/core/core.sip +@@ -1,5 +1,4 @@ + %Module(name=qgis._core, +- version=0, + keyword_arguments="Optional") + + %Feature QT5_SUPPORT +diff --git a/python/core/qgscoordinatetransform.sip b/python/core/qgscoordinatetransform.sip +index c14ba53..f9b7854 100644 +--- a/python/core/qgscoordinatetransform.sip ++++ b/python/core/qgscoordinatetransform.sip +@@ -15,6 +15,7 @@ + class QgsCoordinateTransform : QObject + { + %TypeHeaderCode ++extern PyObject *sipExportedExceptions__core[2]; // workaround: sipExportedExceptions__core is only defined in the first sip part + #include + %End + +@@ -215,5 +216,5 @@ class QgsCoordinateTransform : QObject + + signals: + /** Signal when an invalid pj_transform() has occurred */ +- void invalidTransformInput() const; ++ void invalidTransformInput() const; + }; +diff --git a/python/core/qgsfeature.sip b/python/core/qgsfeature.sip +index 596f8a8..4009b50 100644 +--- a/python/core/qgsfeature.sip ++++ b/python/core/qgsfeature.sip +@@ -4,7 +4,7 @@ typedef QMap QgsAttributeMap; + typedef QVector QgsAttributes; + + // QgsAttributes is implemented as a Python list of Python objects. +-%MappedType QgsAttributes /DocType="list-of-attributes"/ ++%MappedType QgsAttributes + { + %TypeHeaderCode + #include +diff --git a/python/core/qgspallabeling.sip b/python/core/qgspallabeling.sip +index 488b58b..3d99555 100644 +--- a/python/core/qgspallabeling.sip ++++ b/python/core/qgspallabeling.sip +@@ -1,5 +1,5 @@ + // QMap is implemented as a Python dictionary. +-%MappedType QMap /DocType="dict-of-QgsPalLayerSettings.DataDefinedProperties-QgsDataDefined*"/ ++%MappedType QMap + { + %TypeHeaderCode + #include +diff --git a/python/core/qgsvectorlayerfeatureiterator.sip b/python/core/qgsvectorlayerfeatureiterator.sip +index 0685e20..ad3431c 100644 +--- a/python/core/qgsvectorlayerfeatureiterator.sip ++++ b/python/core/qgsvectorlayerfeatureiterator.sip +@@ -70,5 +70,6 @@ class QgsVectorLayerFeatureIterator : QgsAbstractFeatureIterator + //void updateFeatureGeometry( QgsFeature& f ); + + private: +- QgsVectorLayerFeatureIterator(); ++ QgsVectorLayerFeatureIterator( const QgsVectorLayerFeatureIterator &rhs ); ++ + }; +diff --git a/python/core/raster/qgsrasterprojector.sip b/python/core/raster/qgsrasterprojector.sip +index 47bb697..40b9a10 100644 +--- a/python/core/raster/qgsrasterprojector.sip ++++ b/python/core/raster/qgsrasterprojector.sip +@@ -55,7 +55,7 @@ class QgsRasterProjector : QgsRasterInterface + + int bandCount() const; + +- int dataType( int bandNo ) const; ++ QGis::DataType dataType( int bandNo ) const; + + /** \brief set source and destination CRS */ + void setCRS( const QgsCoordinateReferenceSystem & theSrcCRS, const QgsCoordinateReferenceSystem & theDestCRS, +diff --git a/python/gui/editorwidgets/qgsdatetimeedit.sip b/python/gui/editorwidgets/qgsdatetimeedit.sip +index deda76d..be658a1 100644 +--- a/python/gui/editorwidgets/qgsdatetimeedit.sip ++++ b/python/gui/editorwidgets/qgsdatetimeedit.sip +@@ -37,6 +37,7 @@ class QgsDateTimeEdit : QDateTimeEdit + + protected: + virtual void resizeEvent( QResizeEvent* event ); +- + void mousePressEvent( QMouseEvent*event ); ++ virtual void fixup(QString & input) const; ++ virtual QValidator::State validate(QString &text, int &pos) const; + }; +diff --git a/python/gui/editorwidgets/qgsdoublespinbox.sip b/python/gui/editorwidgets/qgsdoublespinbox.sip +index 1666a02..58f589d 100644 +--- a/python/gui/editorwidgets/qgsdoublespinbox.sip ++++ b/python/gui/editorwidgets/qgsdoublespinbox.sip +@@ -80,4 +80,5 @@ class QgsDoubleSpinBox : QDoubleSpinBox + protected: + virtual void changeEvent( QEvent* event ); + virtual void paintEvent( QPaintEvent* event ); ++ virtual void fixup(QString & input) const; + }; +diff --git a/python/gui/editorwidgets/qgsspinbox.sip b/python/gui/editorwidgets/qgsspinbox.sip +index d560641..c953470 100644 +--- a/python/gui/editorwidgets/qgsspinbox.sip ++++ b/python/gui/editorwidgets/qgsspinbox.sip +@@ -78,7 +78,7 @@ class QgsSpinBox : QSpinBox + virtual QValidator::State validate( QString & input, int & pos ) const; + + protected: +- + virtual void changeEvent( QEvent* event ); + virtual void paintEvent( QPaintEvent* event ); ++ virtual void fixup(QString &input) const; + }; +diff --git a/python/gui/gui.sip b/python/gui/gui.sip +index 240c636..727ac707f 100644 +--- a/python/gui/gui.sip ++++ b/python/gui/gui.sip +@@ -1,5 +1,4 @@ + %Module(name=qgis._gui, +- version=0, + keyword_arguments="Optional") + + %Feature HAVE_QSCI_SIP +diff --git a/python/gui/qgslonglongvalidator.sip b/python/gui/qgslonglongvalidator.sip +index 9def830..7500357 100644 +--- a/python/gui/qgslonglongvalidator.sip ++++ b/python/gui/qgslonglongvalidator.sip +@@ -8,7 +8,7 @@ class QgsLongLongValidator : QValidator + QgsLongLongValidator( qint64 bottom, qint64 top, QObject *parent ); + ~QgsLongLongValidator(); + +- QValidator::State validate( QString &input, int& ) const; ++ virtual QValidator::State validate( QString &input, int& ) const; + + void setBottom( qint64 bottom ); + void setTop( qint64 top ); +@@ -17,4 +17,6 @@ class QgsLongLongValidator : QValidator + + qint64 bottom() const; + qint64 top() const; ++ ++ virtual void fixup(QString &input) const; + }; +diff --git a/python/server/qgswmsconfigparser.sip b/python/server/qgswmsconfigparser.sip +index f05752c..d231637 100644 +--- a/python/server/qgswmsconfigparser.sip ++++ b/python/server/qgswmsconfigparser.sip +@@ -115,7 +115,7 @@ class QgsWMSConfigParser + virtual void setScaleDenominator( double denom ) = 0; + virtual void addExternalGMLData( const QString& layerName, QDomDocument* gmlDoc ) = 0; + +- virtual QList< QPair< QString, QgsLayerCoordinateTransform > > layerCoordinateTransforms() const = 0; ++ // virtual QList< QPair< QString, QgsLayerCoordinateTransform > > layerCoordinateTransforms() const = 0; + + virtual int nLayers() const = 0; + +diff --git a/python/server/qgswmsprojectparser.sip b/python/server/qgswmsprojectparser.sip +index f6dd579..13fea73 100644 +--- a/python/server/qgswmsprojectparser.sip ++++ b/python/server/qgswmsprojectparser.sip +@@ -63,7 +63,7 @@ class QgsWMSProjectParser : public QgsWMSConfigParser + void setScaleDenominator( double ) /*override*/; + void addExternalGMLData( const QString&, QDomDocument* ) /*override*/ ; + +- QList< QPair< QString, QgsLayerCoordinateTransform > > layerCoordinateTransforms() const /*override*/ ; ++ // QList< QPair< QString, QgsLayerCoordinateTransform > > layerCoordinateTransforms() const /*override*/ ; + + /** Fills a layer and a style list. The two list have the same number of entries and the style and the layer at a position belong together (similar to the HTTP parameters 'Layers' and 'Styles'. Returns 0 in case of success*/ + int layersAndStyles( QStringList& layers, QStringList& styles ) const /*override*/ ; +diff --git a/python/server/server.sip b/python/server/server.sip +index 537cd0b..355d3fa 100644 +--- a/python/server/server.sip ++++ b/python/server/server.sip +@@ -1,5 +1,4 @@ + %Module(name=qgis._server, +- version=0, + keyword_arguments="Optional") + + diff --git a/qgis.spec b/qgis.spec index c57a5e4..95ae16f 100644 --- a/qgis.spec +++ b/qgis.spec @@ -16,7 +16,7 @@ Name: qgis Version: 2.18.2 -Release: 3%{?dist} +Release: 4%{?dist} Summary: A user friendly Open Source Geographic Information System Group: Applications/Engineering @@ -37,8 +37,13 @@ Source4: %{name}-server-README.fedora Source5: %{name}-mime.xml # Fix builds on 64-bit machines # https://hub.qgis.org/issues/15602 +# https://github.com/qgis/QGIS/commit/718581ffb12b723f9a3c0ae01b7ec2d8aed9d4bb.patch Patch0: %{name}-lib64.patch +# Restore build success with SIP 4.19 +# https://hub.qgis.org/issues/16071 +Patch1: %{name}-2.18.2-sip419.patch + # Some plug-ins need Pyspatialite (bundled) # The license is not totally clear, see: # http://code.google.com/p/pyspatialite/issues/detail?id=3 @@ -183,6 +188,7 @@ Please refer to %{name}-server-README.fedora for details! %prep %setup -q %patch0 -p1 -b .lib64 +%patch1 -p1 -b .sip419 # Remove executable permissions from source code files find . \( -name "*.cpp" -o -name "*.h" \) -type f -perm /111 -execdir chmod -x {} \+ @@ -405,6 +411,9 @@ update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || : %changelog +* Tue Feb 14 2017 Volker Froehlich - 2.18.2-4 +- Apply build patch for SIP 4.19 (#16071) + * Sat Feb 11 2017 Fedora Release Engineering - 2.18.2-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild From 08ea430bf926ce21099b5a40f0a91971eeefb6a4 Mon Sep 17 00:00:00 2001 From: Rex Dieter Date: Mon, 20 Feb 2017 13:07:02 -0600 Subject: [PATCH 5/8] rebuild (qgis) --- qgis.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qgis.spec b/qgis.spec index 95ae16f..9f4bd99 100644 --- a/qgis.spec +++ b/qgis.spec @@ -16,7 +16,7 @@ Name: qgis Version: 2.18.2 -Release: 4%{?dist} +Release: 5%{?dist} Summary: A user friendly Open Source Geographic Information System Group: Applications/Engineering @@ -411,6 +411,9 @@ update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || : %changelog +* Mon Feb 20 2017 Rex Dieter - 2.18.2-5 +- rebuild (qgis) + * Tue Feb 14 2017 Volker Froehlich - 2.18.2-4 - Apply build patch for SIP 4.19 (#16071) From 7dfe643382251f87869277ed5c5d340a2cc6c787 Mon Sep 17 00:00:00 2001 From: Rex Dieter Date: Mon, 20 Feb 2017 13:07:26 -0600 Subject: [PATCH 6/8] qscintilla rebuild --- qgis.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qgis.spec b/qgis.spec index 9f4bd99..b9cd0f6 100644 --- a/qgis.spec +++ b/qgis.spec @@ -412,7 +412,7 @@ update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || : %changelog * Mon Feb 20 2017 Rex Dieter - 2.18.2-5 -- rebuild (qgis) +- rebuild (qscintilla) * Tue Feb 14 2017 Volker Froehlich - 2.18.2-4 - Apply build patch for SIP 4.19 (#16071) From e756dbbffdde6b059ebe332c8ba2ab99e5bdbf62 Mon Sep 17 00:00:00 2001 From: Volker Froehlich Date: Sun, 26 Feb 2017 11:00:06 +0100 Subject: [PATCH 7/8] New upstream release 2.18.4 Remove older patches from repo too --- .gitignore | 1 + qgis-2.12.0-arm.patch | 13 -- qgis-2.14.0-mssql-attributes.patch | 43 ----- qgis-2.18.2-sip419.patch | 256 ----------------------------- qgis-qreal.patch | 24 --- qgis.spec | 12 +- sources | 2 +- 7 files changed, 7 insertions(+), 344 deletions(-) delete mode 100644 qgis-2.12.0-arm.patch delete mode 100644 qgis-2.14.0-mssql-attributes.patch delete mode 100644 qgis-2.18.2-sip419.patch delete mode 100644 qgis-qreal.patch diff --git a/.gitignore b/.gitignore index 09273c9..3b99dc5 100644 --- a/.gitignore +++ b/.gitignore @@ -28,3 +28,4 @@ qgis_1.5.0.tar.gz /qgis-2.18.0.tar.bz2 /qgis-2.18.1.tar.bz2 /qgis-2.18.2.tar.bz2 +/qgis-2.18.4.tar.bz2 diff --git a/qgis-2.12.0-arm.patch b/qgis-2.12.0-arm.patch deleted file mode 100644 index 47e315e..0000000 --- a/qgis-2.12.0-arm.patch +++ /dev/null @@ -1,13 +0,0 @@ -diff --git a/src/app/qgswelcomepageitemsmodel.cpp b/src/app/qgswelcomepageitemsmodel.cpp -index 4a42a6d..5a4b975 100644 ---- a/src/app/qgswelcomepageitemsmodel.cpp -+++ b/src/app/qgswelcomepageitemsmodel.cpp -@@ -114,7 +114,7 @@ QSize QgsWelcomePageItemDelegate::sizeHint( const QStyleOptionViewItem & option, - index.data( QgsWelcomePageItemsModel::CrsRole ).toString() ) ); - doc.setTextWidth( width - ( !icon.isNull() ? icon.width() + 35 : 35 ) ); - -- return QSize( width, qMax( doc.size().height() + 10, ( double )icon.height() ) + 20 ); -+ return QSize( width, qMax( ( double ) doc.size().height() + 10, ( double )icon.height() ) + 20 ); - } - - QgsWelcomePageItemsModel::QgsWelcomePageItemsModel( QObject* parent ) diff --git a/qgis-2.14.0-mssql-attributes.patch b/qgis-2.14.0-mssql-attributes.patch deleted file mode 100644 index 7e44621..0000000 --- a/qgis-2.14.0-mssql-attributes.patch +++ /dev/null @@ -1,43 +0,0 @@ -From 30449e577f0cd432bd8c60787743fba54c1e51b9 Mon Sep 17 00:00:00 2001 -From: Nyall Dawson -Date: Thu, 3 Mar 2016 10:34:32 +1100 -Subject: [PATCH] Fix fetching subset of attributes with mssql (fix #14402), - add test - ---- - src/providers/mssql/qgsmssqlfeatureiterator.cpp | 2 +- - tests/src/python/providertestbase.py | 11 +++++++++++ - 2 files changed, 12 insertions(+), 1 deletion(-) - -diff --git a/src/providers/mssql/qgsmssqlfeatureiterator.cpp b/src/providers/mssql/qgsmssqlfeatureiterator.cpp -index 53214d4..560d344 100644 ---- a/src/providers/mssql/qgsmssqlfeatureiterator.cpp -+++ b/src/providers/mssql/qgsmssqlfeatureiterator.cpp -@@ -284,7 +284,7 @@ bool QgsMssqlFeatureIterator::fetchFeature( QgsFeature& feature ) - for ( int i = 0; i < mAttributesToFetch.count(); i++ ) - { - QVariant v = mQuery->value( i ); -- const QgsField &fld = mSource->mFields.at( i ); -+ const QgsField &fld = mSource->mFields.at( mAttributesToFetch.at( i ) ); - if ( v.type() != fld.type() ) - v = QgsVectorDataProvider::convertValue( fld.type(), v.toString() ); - feature.setAttribute( mAttributesToFetch.at( i ), v ); -diff --git a/tests/src/python/providertestbase.py b/tests/src/python/providertestbase.py -index 7b8707e..26e6d86 100644 ---- a/tests/src/python/providertestbase.py -+++ b/tests/src/python/providertestbase.py -@@ -384,3 +384,14 @@ def testClosedIterators(self): - - # Test rewinding closed iterator - self.assertFalse(f_it.rewind(), 'Rewinding closed iterator successful, should not be allowed') -+ -+ def testGetFeaturesSubsetAttributes(self): -+ """ Test that expected results are returned when using subsets of attributes """ -+ -+ tests = {'pk': set([1, 2, 3, 4, 5]), -+ 'cnt': set([-200, 300, 100, 200, 400]), -+ 'name': set(['Pear', 'Orange', 'Apple', 'Honey', NULL]), -+ 'name2': set(['NuLl', 'PEaR', 'oranGe', 'Apple', 'Honey'])} -+ for field, expected in tests.iteritems(): -+ result = set([f[field] for f in self.provider.getFeatures(QgsFeatureRequest().setSubsetOfAttributes([field], self.provider.fields()))]) -+ self.assertEqual(result, expected, 'Expected {}, got {}'.format(expected, result)) diff --git a/qgis-2.18.2-sip419.patch b/qgis-2.18.2-sip419.patch deleted file mode 100644 index 5f64293..0000000 --- a/qgis-2.18.2-sip419.patch +++ /dev/null @@ -1,256 +0,0 @@ -From 718581ffb12b723f9a3c0ae01b7ec2d8aed9d4bb Mon Sep 17 00:00:00 2001 -From: "Juergen E. Fischer" -Date: Sat, 11 Feb 2017 21:02:05 +0100 -Subject: [PATCH] adapt bindings to sip 4.19 (fixes #16071) - ---- - python/analysis/analysis.sip | 1 - - python/analysis/network/networkanalysis.sip | 1 - - python/core/conversions.sip | 6 +++--- - python/core/core.sip | 1 - - python/core/qgscoordinatetransform.sip | 3 ++- - python/core/qgsfeature.sip | 2 +- - python/core/qgspallabeling.sip | 2 +- - python/core/qgsvectorlayerfeatureiterator.sip | 3 ++- - python/core/raster/qgsrasterprojector.sip | 2 +- - python/gui/editorwidgets/qgsdatetimeedit.sip | 3 ++- - python/gui/editorwidgets/qgsdoublespinbox.sip | 1 + - python/gui/editorwidgets/qgsspinbox.sip | 2 +- - python/gui/gui.sip | 1 - - python/gui/qgslonglongvalidator.sip | 4 +++- - python/server/qgswmsconfigparser.sip | 2 +- - python/server/qgswmsprojectparser.sip | 2 +- - python/server/server.sip | 1 - - 17 files changed, 19 insertions(+), 18 deletions(-) - -diff --git a/python/analysis/analysis.sip b/python/analysis/analysis.sip -index ceb5056..bd90e10 100644 ---- a/python/analysis/analysis.sip -+++ b/python/analysis/analysis.sip -@@ -1,5 +1,4 @@ - %Module(name=qgis._analysis, -- version=0, - keyword_arguments="Optional") - - %Import QtCore/QtCoremod.sip -diff --git a/python/analysis/network/networkanalysis.sip b/python/analysis/network/networkanalysis.sip -index fb446d1..d2c192b 100644 ---- a/python/analysis/network/networkanalysis.sip -+++ b/python/analysis/network/networkanalysis.sip -@@ -1,5 +1,4 @@ - %Module(name=qgis._networkanalysis, -- version=0, - keyword_arguments="Optional") - - %Import QtCore/QtCoremod.sip -diff --git a/python/core/conversions.sip b/python/core/conversions.sip -index 564d4de..f07d3ab 100644 ---- a/python/core/conversions.sip -+++ b/python/core/conversions.sip -@@ -747,7 +747,7 @@ template - - // QMap is implemented as a Python dictionary. - template --%MappedType QMap /DocType="dict-of-qint64-TYPE"/ -+%MappedType QMap - { - %TypeHeaderCode - #include -@@ -1873,7 +1873,7 @@ template - }; - - // QList is implemented as a Python list of QgsField. --%MappedType QList /DocType="list-of-qgsfield"/ -+%MappedType QList - { - %TypeHeaderCode - #include -@@ -1978,7 +1978,7 @@ template - - %If (QVECTORINT_CONVERSION) - // QVector is implemented as a Python list of integers. --%MappedType QVector /DocType="list-of-int"/ -+%MappedType QVector - { - %TypeHeaderCode - #include -diff --git a/python/core/core.sip b/python/core/core.sip -index 577c4c1..8f0b6af 100644 ---- a/python/core/core.sip -+++ b/python/core/core.sip -@@ -1,5 +1,4 @@ - %Module(name=qgis._core, -- version=0, - keyword_arguments="Optional") - - %Feature QT5_SUPPORT -diff --git a/python/core/qgscoordinatetransform.sip b/python/core/qgscoordinatetransform.sip -index c14ba53..f9b7854 100644 ---- a/python/core/qgscoordinatetransform.sip -+++ b/python/core/qgscoordinatetransform.sip -@@ -15,6 +15,7 @@ - class QgsCoordinateTransform : QObject - { - %TypeHeaderCode -+extern PyObject *sipExportedExceptions__core[2]; // workaround: sipExportedExceptions__core is only defined in the first sip part - #include - %End - -@@ -215,5 +216,5 @@ class QgsCoordinateTransform : QObject - - signals: - /** Signal when an invalid pj_transform() has occurred */ -- void invalidTransformInput() const; -+ void invalidTransformInput() const; - }; -diff --git a/python/core/qgsfeature.sip b/python/core/qgsfeature.sip -index 596f8a8..4009b50 100644 ---- a/python/core/qgsfeature.sip -+++ b/python/core/qgsfeature.sip -@@ -4,7 +4,7 @@ typedef QMap QgsAttributeMap; - typedef QVector QgsAttributes; - - // QgsAttributes is implemented as a Python list of Python objects. --%MappedType QgsAttributes /DocType="list-of-attributes"/ -+%MappedType QgsAttributes - { - %TypeHeaderCode - #include -diff --git a/python/core/qgspallabeling.sip b/python/core/qgspallabeling.sip -index 488b58b..3d99555 100644 ---- a/python/core/qgspallabeling.sip -+++ b/python/core/qgspallabeling.sip -@@ -1,5 +1,5 @@ - // QMap is implemented as a Python dictionary. --%MappedType QMap /DocType="dict-of-QgsPalLayerSettings.DataDefinedProperties-QgsDataDefined*"/ -+%MappedType QMap - { - %TypeHeaderCode - #include -diff --git a/python/core/qgsvectorlayerfeatureiterator.sip b/python/core/qgsvectorlayerfeatureiterator.sip -index 0685e20..ad3431c 100644 ---- a/python/core/qgsvectorlayerfeatureiterator.sip -+++ b/python/core/qgsvectorlayerfeatureiterator.sip -@@ -70,5 +70,6 @@ class QgsVectorLayerFeatureIterator : QgsAbstractFeatureIterator - //void updateFeatureGeometry( QgsFeature& f ); - - private: -- QgsVectorLayerFeatureIterator(); -+ QgsVectorLayerFeatureIterator( const QgsVectorLayerFeatureIterator &rhs ); -+ - }; -diff --git a/python/core/raster/qgsrasterprojector.sip b/python/core/raster/qgsrasterprojector.sip -index 47bb697..40b9a10 100644 ---- a/python/core/raster/qgsrasterprojector.sip -+++ b/python/core/raster/qgsrasterprojector.sip -@@ -55,7 +55,7 @@ class QgsRasterProjector : QgsRasterInterface - - int bandCount() const; - -- int dataType( int bandNo ) const; -+ QGis::DataType dataType( int bandNo ) const; - - /** \brief set source and destination CRS */ - void setCRS( const QgsCoordinateReferenceSystem & theSrcCRS, const QgsCoordinateReferenceSystem & theDestCRS, -diff --git a/python/gui/editorwidgets/qgsdatetimeedit.sip b/python/gui/editorwidgets/qgsdatetimeedit.sip -index deda76d..be658a1 100644 ---- a/python/gui/editorwidgets/qgsdatetimeedit.sip -+++ b/python/gui/editorwidgets/qgsdatetimeedit.sip -@@ -37,6 +37,7 @@ class QgsDateTimeEdit : QDateTimeEdit - - protected: - virtual void resizeEvent( QResizeEvent* event ); -- - void mousePressEvent( QMouseEvent*event ); -+ virtual void fixup(QString & input) const; -+ virtual QValidator::State validate(QString &text, int &pos) const; - }; -diff --git a/python/gui/editorwidgets/qgsdoublespinbox.sip b/python/gui/editorwidgets/qgsdoublespinbox.sip -index 1666a02..58f589d 100644 ---- a/python/gui/editorwidgets/qgsdoublespinbox.sip -+++ b/python/gui/editorwidgets/qgsdoublespinbox.sip -@@ -80,4 +80,5 @@ class QgsDoubleSpinBox : QDoubleSpinBox - protected: - virtual void changeEvent( QEvent* event ); - virtual void paintEvent( QPaintEvent* event ); -+ virtual void fixup(QString & input) const; - }; -diff --git a/python/gui/editorwidgets/qgsspinbox.sip b/python/gui/editorwidgets/qgsspinbox.sip -index d560641..c953470 100644 ---- a/python/gui/editorwidgets/qgsspinbox.sip -+++ b/python/gui/editorwidgets/qgsspinbox.sip -@@ -78,7 +78,7 @@ class QgsSpinBox : QSpinBox - virtual QValidator::State validate( QString & input, int & pos ) const; - - protected: -- - virtual void changeEvent( QEvent* event ); - virtual void paintEvent( QPaintEvent* event ); -+ virtual void fixup(QString &input) const; - }; -diff --git a/python/gui/gui.sip b/python/gui/gui.sip -index 240c636..727ac707f 100644 ---- a/python/gui/gui.sip -+++ b/python/gui/gui.sip -@@ -1,5 +1,4 @@ - %Module(name=qgis._gui, -- version=0, - keyword_arguments="Optional") - - %Feature HAVE_QSCI_SIP -diff --git a/python/gui/qgslonglongvalidator.sip b/python/gui/qgslonglongvalidator.sip -index 9def830..7500357 100644 ---- a/python/gui/qgslonglongvalidator.sip -+++ b/python/gui/qgslonglongvalidator.sip -@@ -8,7 +8,7 @@ class QgsLongLongValidator : QValidator - QgsLongLongValidator( qint64 bottom, qint64 top, QObject *parent ); - ~QgsLongLongValidator(); - -- QValidator::State validate( QString &input, int& ) const; -+ virtual QValidator::State validate( QString &input, int& ) const; - - void setBottom( qint64 bottom ); - void setTop( qint64 top ); -@@ -17,4 +17,6 @@ class QgsLongLongValidator : QValidator - - qint64 bottom() const; - qint64 top() const; -+ -+ virtual void fixup(QString &input) const; - }; -diff --git a/python/server/qgswmsconfigparser.sip b/python/server/qgswmsconfigparser.sip -index f05752c..d231637 100644 ---- a/python/server/qgswmsconfigparser.sip -+++ b/python/server/qgswmsconfigparser.sip -@@ -115,7 +115,7 @@ class QgsWMSConfigParser - virtual void setScaleDenominator( double denom ) = 0; - virtual void addExternalGMLData( const QString& layerName, QDomDocument* gmlDoc ) = 0; - -- virtual QList< QPair< QString, QgsLayerCoordinateTransform > > layerCoordinateTransforms() const = 0; -+ // virtual QList< QPair< QString, QgsLayerCoordinateTransform > > layerCoordinateTransforms() const = 0; - - virtual int nLayers() const = 0; - -diff --git a/python/server/qgswmsprojectparser.sip b/python/server/qgswmsprojectparser.sip -index f6dd579..13fea73 100644 ---- a/python/server/qgswmsprojectparser.sip -+++ b/python/server/qgswmsprojectparser.sip -@@ -63,7 +63,7 @@ class QgsWMSProjectParser : public QgsWMSConfigParser - void setScaleDenominator( double ) /*override*/; - void addExternalGMLData( const QString&, QDomDocument* ) /*override*/ ; - -- QList< QPair< QString, QgsLayerCoordinateTransform > > layerCoordinateTransforms() const /*override*/ ; -+ // QList< QPair< QString, QgsLayerCoordinateTransform > > layerCoordinateTransforms() const /*override*/ ; - - /** Fills a layer and a style list. The two list have the same number of entries and the style and the layer at a position belong together (similar to the HTTP parameters 'Layers' and 'Styles'. Returns 0 in case of success*/ - int layersAndStyles( QStringList& layers, QStringList& styles ) const /*override*/ ; -diff --git a/python/server/server.sip b/python/server/server.sip -index 537cd0b..355d3fa 100644 ---- a/python/server/server.sip -+++ b/python/server/server.sip -@@ -1,5 +1,4 @@ - %Module(name=qgis._server, -- version=0, - keyword_arguments="Optional") - - diff --git a/qgis-qreal.patch b/qgis-qreal.patch deleted file mode 100644 index 8dfc1be..0000000 --- a/qgis-qreal.patch +++ /dev/null @@ -1,24 +0,0 @@ -diff -up qgis-2.16.2/src/gui/symbology-ng/qgsvectorgradientcolorrampv2dialog.cpp.qreal qgis-2.16.2/src/gui/symbology-ng/qgsvectorgradientcolorrampv2dialog.cpp ---- qgis-2.16.2/src/gui/symbology-ng/qgsvectorgradientcolorrampv2dialog.cpp.qreal 2016-08-26 05:58:37.000000000 -0600 -+++ qgis-2.16.2/src/gui/symbology-ng/qgsvectorgradientcolorrampv2dialog.cpp 2016-09-26 14:27:41.330518186 -0600 -@@ -414,15 +414,15 @@ void QgsVectorGradientColorRampV2Dialog: - QColor newColor = mStopEditor->selectedStop().color; - - if ( mCurrentPlotColorComponent == 0 ) -- newColor = QColor::fromHslF( qBound( 0.0, point.y(), 1.0 ), newColor.hslSaturationF(), newColor.lightnessF(), newColor.alphaF() ); -+ newColor = QColor::fromHslF( qBound( qreal( 0.0 ), point.y(), qreal( 1.0 ) ), newColor.hslSaturationF(), newColor.lightnessF(), newColor.alphaF() ); - else if ( mCurrentPlotColorComponent == 1 ) -- newColor = QColor::fromHslF( newColor.hslHueF(), newColor.hslSaturationF(), qBound( 0.0, point.y(), 1.0 ), newColor.alphaF() ); -+ newColor = QColor::fromHslF( newColor.hslHueF(), newColor.hslSaturationF(), qBound( qreal( 0.0 ), point.y(), qreal( 1.0 ) ), newColor.alphaF() ); - else if ( mCurrentPlotColorComponent == 2 ) -- newColor = QColor::fromHslF( newColor.hslHueF(), qBound( 0.0, point.y(), 1.0 ), newColor.lightnessF(), newColor.alphaF() ); -+ newColor = QColor::fromHslF( newColor.hslHueF(), qBound( qreal( 0.0 ), point.y(), qreal( 1.0 ) ), newColor.lightnessF(), newColor.alphaF() ); - else if ( mCurrentPlotColorComponent == 3 ) -- newColor = QColor::fromHslF( newColor.hslHueF(), newColor.hslSaturationF(), newColor.lightnessF(), qBound( 0.0, point.y(), 1.0 ) ); -+ newColor = QColor::fromHslF( newColor.hslHueF(), newColor.hslSaturationF(), newColor.lightnessF(), qBound( qreal( 0.0 ), point.y(), qreal( 1.0 ) ) ); - -- mStopEditor->setSelectedStopDetails( newColor, qBound( 0.0, point.x(), 1.0 ) ); -+ mStopEditor->setSelectedStopDetails( newColor, qBound( qreal( 0.0 ), point.x(), qreal( 1.0 ) ) ); - } - - bool byX( QPointF p1, QPointF p2 ) diff --git a/qgis.spec b/qgis.spec index b9cd0f6..94cd865 100644 --- a/qgis.spec +++ b/qgis.spec @@ -15,8 +15,8 @@ #TODO: Run test suite (see debian/rules) Name: qgis -Version: 2.18.2 -Release: 5%{?dist} +Version: 2.18.4 +Release: 1%{?dist} Summary: A user friendly Open Source Geographic Information System Group: Applications/Engineering @@ -40,10 +40,6 @@ Source5: %{name}-mime.xml # https://github.com/qgis/QGIS/commit/718581ffb12b723f9a3c0ae01b7ec2d8aed9d4bb.patch Patch0: %{name}-lib64.patch -# Restore build success with SIP 4.19 -# https://hub.qgis.org/issues/16071 -Patch1: %{name}-2.18.2-sip419.patch - # Some plug-ins need Pyspatialite (bundled) # The license is not totally clear, see: # http://code.google.com/p/pyspatialite/issues/detail?id=3 @@ -188,7 +184,6 @@ Please refer to %{name}-server-README.fedora for details! %prep %setup -q %patch0 -p1 -b .lib64 -%patch1 -p1 -b .sip419 # Remove executable permissions from source code files find . \( -name "*.cpp" -o -name "*.h" \) -type f -perm /111 -execdir chmod -x {} \+ @@ -411,6 +406,9 @@ update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || : %changelog +* Fri Feb 24 2017 Volker Froehlich - 2.18.4-1 +- New upstream release + * Mon Feb 20 2017 Rex Dieter - 2.18.2-5 - rebuild (qscintilla) diff --git a/sources b/sources index 634214e..351a6e5 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (qgis-2.18.2.tar.bz2) = b78bc4f109015f943fa019f0c03208496626d8eae1887eddf975f5fdf81f455db47428b8051a3d02ae46e0482bd7c955871b7d5ead5a70205f6525f085dcbf7f +SHA512 (qgis-2.18.4.tar.bz2) = 3938fbc1f87990a08411ba8f793d7900f10eaea1824a5a9d2217ca0dea1a8b0849ec91c41be50dc65f590713391bb613429bf48f9ea0ffaaba876dde35b98fc7 From 25b8f81ccabbfdb183d4850a66e884c183444f14 Mon Sep 17 00:00:00 2001 From: Sandro Mani Date: Thu, 2 Mar 2017 00:18:52 +0100 Subject: [PATCH 8/8] Add patch to fix FTBFS --- qgis.spec | 12 ++- qgis_sip-ftbfs.patch | 202 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 213 insertions(+), 1 deletion(-) create mode 100644 qgis_sip-ftbfs.patch diff --git a/qgis.spec b/qgis.spec index 94cd865..e5e7c31 100644 --- a/qgis.spec +++ b/qgis.spec @@ -16,7 +16,7 @@ Name: qgis Version: 2.18.4 -Release: 1%{?dist} +Release: 2%{?dist} Summary: A user friendly Open Source Geographic Information System Group: Applications/Engineering @@ -40,6 +40,12 @@ Source5: %{name}-mime.xml # https://github.com/qgis/QGIS/commit/718581ffb12b723f9a3c0ae01b7ec2d8aed9d4bb.patch Patch0: %{name}-lib64.patch +# Fix some SIP related FTBFS issues +# upstream fix: qgsfiledownloader.sip:33:0: src/gui/qgsfiledownloader.h:94:5: error: overriding non-deleted function 'virtual QgsFileDownloader::~QgsFileDownloader()' +# workaround (?): RuntimeError: qgis._core cannot import type 'QList' from PyQt4.QtCore +# workaround (?): RuntimeError: qgis._core cannot import type 'QList' from PyQt4.QtCore +Patch1: qgis_sip-ftbfs.patch + # Some plug-ins need Pyspatialite (bundled) # The license is not totally clear, see: # http://code.google.com/p/pyspatialite/issues/detail?id=3 @@ -184,6 +190,7 @@ Please refer to %{name}-server-README.fedora for details! %prep %setup -q %patch0 -p1 -b .lib64 +%patch1 -p1 -b .sip # Remove executable permissions from source code files find . \( -name "*.cpp" -o -name "*.h" \) -type f -perm /111 -execdir chmod -x {} \+ @@ -406,6 +413,9 @@ update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || : %changelog +* Wed Mar 01 2017 Sandro Mani - 2.18.4-2 +- Add patch to fix FTBFS + * Fri Feb 24 2017 Volker Froehlich - 2.18.4-1 - New upstream release diff --git a/qgis_sip-ftbfs.patch b/qgis_sip-ftbfs.patch new file mode 100644 index 0000000..01fefa8 --- /dev/null +++ b/qgis_sip-ftbfs.patch @@ -0,0 +1,202 @@ +diff --git a/python/core/conversions.sip b/python/core/conversions.sip +index f07d3ab1db..948821e91e 100644 +--- a/python/core/conversions.sip ++++ b/python/core/conversions.sip +@@ -2041,3 +2041,178 @@ register_from_qvariant_convertor = (void (*)(FromQVariantConvertorFn))sipImportS + register_from_qvariant_convertor(null_from_qvariant_convertor); + %End + %End ++ ++// QList is implemented as a Python list. ++%MappedType QList /TypeHintIn="Sequence[QVariant]", TypeHintOut="List[QVariant]", TypeHintValue="[]"/ ++{ ++%TypeHeaderCode ++#include ++%End ++ ++%ConvertFromTypeCode ++ // Create the list. ++ PyObject *l; ++ ++ if ((l = PyList_New(sipCpp->size())) == NULL) ++ return NULL; ++ ++ // Set the list elements. ++ for (int i = 0; i < sipCpp->size(); ++i) ++ { ++ QVariant *t = new QVariant(sipCpp->at(i)); ++ PyObject *tobj; ++ ++ if ((tobj = sipConvertFromNewType(t, sipType_QVariant, sipTransferObj)) == NULL) ++ { ++ Py_DECREF(l); ++ delete t; ++ ++ return NULL; ++ } ++ ++ PyList_SET_ITEM(l, i, tobj); ++ } ++ ++ return l; ++%End ++ ++%ConvertToTypeCode ++ SIP_SSIZE_T len; ++ ++ // Check the type if that is all that is required. ++ if (sipIsErr == NULL) ++ { ++ if (!PySequence_Check(sipPy) || (len = PySequence_Size(sipPy)) < 0) ++ return 0; ++ ++ for (SIP_SSIZE_T i = 0; i < len; ++i) ++ { ++ PyObject *itm = PySequence_ITEM(sipPy, i); ++ bool ok = (itm && sipCanConvertToType(itm, sipType_QVariant, SIP_NOT_NONE)); ++ ++ Py_XDECREF(itm); ++ ++ if (!ok) ++ return 0; ++ } ++ ++ return 1; ++ } ++ ++ QList *ql = new QList; ++ len = PySequence_Size(sipPy); ++ ++ for (SIP_SSIZE_T i = 0; i < len; ++i) ++ { ++ PyObject *itm = PySequence_ITEM(sipPy, i); ++ int state; ++ QVariant *t = reinterpret_cast(sipConvertToType(itm, sipType_QVariant, sipTransferObj, SIP_NOT_NONE, &state, sipIsErr)); ++ ++ Py_DECREF(itm); ++ ++ if (*sipIsErr) ++ { ++ sipReleaseType(t, sipType_QVariant, state); ++ ++ delete ql; ++ return 0; ++ } ++ ++ ql->append(*t); ++ ++ sipReleaseType(t, sipType_QVariant, state); ++ } ++ ++ *sipCppPtr = ql; ++ ++ return sipGetState(sipTransferObj); ++%End ++}; ++ ++ ++// QList is implemented as a Python list. ++%MappedType QList /TypeHintIn="Sequence[QPolygonF]", TypeHintOut="List[QPolygonF]", TypeHintValue="[]"/ ++{ ++%TypeHeaderCode ++#include ++%End ++ ++%ConvertFromTypeCode ++ // Create the list. ++ PyObject *l; ++ ++ if ((l = PyList_New(sipCpp->size())) == NULL) ++ return NULL; ++ ++ // Set the list elements. ++ for (int i = 0; i < sipCpp->size(); ++i) ++ { ++ QPolygonF *t = new QPolygonF(sipCpp->at(i)); ++ PyObject *tobj; ++ ++ if ((tobj = sipConvertFromNewType(t, sipType_QPolygonF, sipTransferObj)) == NULL) ++ { ++ Py_DECREF(l); ++ delete t; ++ ++ return NULL; ++ } ++ ++ PyList_SET_ITEM(l, i, tobj); ++ } ++ ++ return l; ++%End ++ ++%ConvertToTypeCode ++ SIP_SSIZE_T len; ++ ++ // Check the type if that is all that is required. ++ if (sipIsErr == NULL) ++ { ++ if (!PySequence_Check(sipPy) || (len = PySequence_Size(sipPy)) < 0) ++ return 0; ++ ++ for (SIP_SSIZE_T i = 0; i < len; ++i) ++ { ++ PyObject *itm = PySequence_ITEM(sipPy, i); ++ bool ok = (itm && sipCanConvertToType(itm, sipType_QPolygonF, SIP_NOT_NONE)); ++ ++ Py_XDECREF(itm); ++ ++ if (!ok) ++ return 0; ++ } ++ ++ return 1; ++ } ++ ++ QList *ql = new QList; ++ len = PySequence_Size(sipPy); ++ ++ for (SIP_SSIZE_T i = 0; i < len; ++i) ++ { ++ PyObject *itm = PySequence_ITEM(sipPy, i); ++ int state; ++ QPolygonF *t = reinterpret_cast(sipConvertToType(itm, sipType_QPolygonF, sipTransferObj, SIP_NOT_NONE, &state, sipIsErr)); ++ ++ Py_DECREF(itm); ++ ++ if (*sipIsErr) ++ { ++ sipReleaseType(t, sipType_QPolygonF, state); ++ ++ delete ql; ++ return 0; ++ } ++ ++ ql->append(*t); ++ ++ sipReleaseType(t, sipType_QPolygonF, state); ++ } ++ ++ *sipCppPtr = ql; ++ ++ return sipGetState(sipTransferObj); ++%End ++}; +diff --git a/src/gui/qgsfiledownloader.h b/src/gui/qgsfiledownloader.h +index c9276f7caf..841e4b6ee1 100644 +--- a/src/gui/qgsfiledownloader.h ++++ b/src/gui/qgsfiledownloader.h +@@ -90,8 +90,10 @@ class GUI_EXPORT QgsFileDownloader : public QObject + void onSslErrors( QNetworkReply *reply, const QList &errors ); + #endif + +- private: ++ protected: + ~QgsFileDownloader(); ++ ++ private: + /** + * Abort current request and show an error if the instance has GUI + * notifications enabled. +-- +2.12.0 +