Change how images and consists are sorted (#14)

ram/consist/migrations/0008_alter_consist_options.py

@@ -0,0 +1,17 @@
+# Generated by Django 4.1.3 on 2023-01-02 15:03
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("consist", "0007_alter_consist_image"),
+    ]
+
+    operations = [
+        migrations.AlterModelOptions(
+            name="consist",
+            options={"ordering": ["company", "-creation_time"]},
+        ),
+    ]

ram/consist/models.py

@@ -32,7 +32,7 @@ class Consist(models.Model):
         return reverse("consist", kwargs={"uuid": self.uuid})
 
     class Meta:
-        ordering = ["creation_time"]
+        ordering = ["company", "-creation_time"]
 
 
 class ConsistItem(models.Model):

ram/portal/templates/base.html

@@ -100,7 +100,7 @@
             <div class="col">
               <div class="card shadow-sm">
                 {% for i in r.image.all %}
-                {% if i.is_thumbnail %}<a href="{{r.get_absolute_url}}"><img src="{{ i.image.url }}" alt="Card image cap"></a>{% endif %}
+                {% if forloop.first %}<a href="{{r.get_absolute_url}}"><img src="{{ i.image.url }}" alt="Card image cap"></a>{% endif %}
                 {% endfor %}
                 <div class="card-body">
                   <p class="card-text" style="position: relative;">

ram/portal/templates/consist.html

@@ -15,7 +15,7 @@
       <div class="col">
         <div class="card shadow-sm">
           {% for i in r.rolling_stock.image.all %}
-          {% if i.is_thumbnail %}<a href="{{r.rolling_stock.get_absolute_url}}"><img src="{{ i.image.url }}" alt="Card image cap"></a>{% endif %}
+          {% if forloop.first %}<a href="{{r.rolling_stock.get_absolute_url}}"><img src="{{ i.image.url }}" alt="Card image cap"></a>{% endif %}
           {% endfor %}
           <div class="card-body">
             <p class="card-text" style="position: relative;">

ram/portal/templates/consists.html

@@ -10,7 +10,7 @@
           {% else %}
             {% with c.consist_item.first.rolling_stock as r %}
             {% for i in r.image.all %}
-              {% if i.is_thumbnail %}<img src="{{ i.image.url }}" alt="Card image cap">{% endif %}
+              {% if forloop.first %}<img src="{{ i.image.url }}" alt="Card image cap">{% endif %}
             {% endfor %}
             {% endwith %}
           {% endif %}

ram/ram/__init__.py

@@ -1,4 +1,4 @@
 from ram.utils import git_suffix
 
-__version__ = "0.0.23"
+__version__ = "0.0.24"
 __version__ += git_suffix(__file__)

ram/roster/admin.py

@@ -1,4 +1,6 @@
 from django.contrib import admin
+from adminsortable2.admin import SortableAdminBase, SortableInlineAdminMixin
+
 from roster.models import (
     RollingClass,
     RollingClassProperty,
@@ -35,7 +37,7 @@ class RollingStockDocInline(admin.TabularInline):
     classes = ["collapse"]
 
 
-class RollingStockImageInline(admin.TabularInline):
+class RollingStockImageInline(SortableInlineAdminMixin, admin.TabularInline):
     model = RollingStockImage
     min_num = 0
     extra = 0
@@ -93,7 +95,7 @@ class RollingJournalDocumentAdmin(admin.ModelAdmin):
 
 
 @admin.register(RollingStock)
-class RollingStockAdmin(admin.ModelAdmin):
+class RollingStockAdmin(SortableAdminBase, admin.ModelAdmin):
     inlines = (
         RollingStockPropertyInline,
         RollingStockImageInline,

ram/roster/migrations/0016_alter_rollingstockimage_options_and_more.py

@@ -0,0 +1,22 @@
+# Generated by Django 4.1.3 on 2023-01-02 12:34
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("roster", "0015_alter_rollingstockimage_options"),
+    ]
+
+    operations = [
+        migrations.AlterModelOptions(
+            name="rollingstockimage",
+            options={"ordering": ["order"]},
+        ),
+        migrations.AddField(
+            model_name="rollingstockimage",
+            name="order",
+            field=models.PositiveIntegerField(default=0),
+        ),
+    ]

ram/roster/migrations/0017_remove_rollingstockimage_is_thumbnail.py

@@ -0,0 +1,17 @@
+# Generated by Django 4.1.3 on 2023-01-02 15:02
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("roster", "0016_alter_rollingstockimage_options_and_more"),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="rollingstockimage",
+            name="is_thumbnail",
+        ),
+    ]

ram/roster/models.py

@@ -155,13 +155,13 @@ class RollingStockDocument(models.Model):
 
 
 class RollingStockImage(models.Model):
+    order = models.PositiveIntegerField(default=0, blank=False, null=False)
     rolling_stock = models.ForeignKey(
         RollingStock, on_delete=models.CASCADE, related_name="image"
     )
     image = models.ImageField(
         upload_to="images/", storage=DeduplicatedStorage, null=True, blank=True
     )
-    is_thumbnail = models.BooleanField()
 
     def image_thumbnail(self):
         return get_image_preview(self.image.url)
@@ -171,15 +171,8 @@ class RollingStockImage(models.Model):
     def __str__(self):
         return "{0}".format(os.path.basename(self.image.name))
 
-    def save(self, **kwargs):
-        if self.is_thumbnail:
-            RollingStockImage.objects.filter(
-                rolling_stock=self.rolling_stock
-            ).update(is_thumbnail=False)
-        super().save(**kwargs)
-
     class Meta:
-        ordering = ["-is_thumbnail"]
+        ordering = ["order"]
 
 
 class RollingStockProperty(models.Model):