Update submodules

.github/workflows/django.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       max-parallel: 2
       matrix:
-        python-version: ['3.12', '3.13']
+        python-version: ['3.13', '3.14']
 
     steps:
     - uses: actions/checkout@v3

ram/bookshelf/admin.py

@@ -2,7 +2,7 @@ import html
 
 from django.conf import settings
 from django.contrib import admin
-from django.utils.html import format_html, strip_tags
+from django.utils.html import format_html, format_html_join, strip_tags
 from adminsortable2.admin import SortableAdminBase, SortableInlineAdminMixin
 
 from ram.admin import publish, unpublish
@@ -76,7 +76,7 @@ class BookAdmin(SortableAdminBase, admin.ModelAdmin):
     autocomplete_fields = ("authors", "publisher", "shop")
     readonly_fields = ("invoices", "creation_time", "updated_time")
     search_fields = ("title", "publisher__name", "authors__last_name")
-    list_filter = ("publisher__name", "authors")
+    list_filter = ("publisher__name", "authors", "published")
 
     fieldsets = (
         (
@@ -133,13 +133,14 @@ class BookAdmin(SortableAdminBase, admin.ModelAdmin):
     @admin.display(description="Invoices")
     def invoices(self, obj):
         if obj.invoice.exists():
-            html = "<br>".join(
-                "<a href=\"{}\" target=\"_blank\">{}</a>".format(
-                    i.file.url, i
-                ) for i in obj.invoice.all())
+            html = format_html_join(
+                "<br>",
+                "<a href=\"{}\" target=\"_blank\">{}</a>",
+                ((i.file.url, i) for i in obj.invoice.all())
+            )
         else:
             html = "-"
-        return format_html(html)
+        return html
 
     @admin.display(description="Publisher")
     def get_publisher(self, obj):
@@ -217,7 +218,7 @@ class PublisherAdmin(admin.ModelAdmin):
     @admin.display(description="Country")
     def country_flag(self, obj):
         return format_html(
-            '<img src="{}" /> {}'.format(obj.country.flag, obj.country.name)
+            '<img src="{}" /> {}', obj.country.flag, obj.country.name
         )
 
 
@@ -238,7 +239,12 @@ class CatalogAdmin(SortableAdminBase, admin.ModelAdmin):
     autocomplete_fields = ("manufacturer",)
     readonly_fields = ("invoices", "creation_time", "updated_time")
     search_fields = ("manufacturer__name", "years", "scales__scale")
-    list_filter = ("manufacturer__name", "publication_year", "scales__scale")
+    list_filter = (
+        "manufacturer__name",
+        "publication_year",
+        "scales__scale",
+        "published",
+    )
 
     fieldsets = (
         (
@@ -295,13 +301,14 @@ class CatalogAdmin(SortableAdminBase, admin.ModelAdmin):
     @admin.display(description="Invoices")
     def invoices(self, obj):
         if obj.invoice.exists():
-            html = "<br>".join(
-                "<a href=\"{}\" target=\"_blank\">{}</a>".format(
-                    i.file.url, i
-                ) for i in obj.invoice.all())
+            html = format_html_join(
+                "<br>",
+                "<a href=\"{}\" target=\"_blank\">{}</a>",
+                ((i.file.url, i) for i in obj.invoice.all())
+            )
         else:
             html = "-"
-        return format_html(html)
+        return html
 
     def download_csv(modeladmin, request, queryset):
         header = [
@@ -356,8 +363,8 @@ class CatalogAdmin(SortableAdminBase, admin.ModelAdmin):
     actions = [publish, unpublish, download_csv]
 
 
-@admin.register(Issue)
-class MagazineIssueAdmin(admin.ModelAdmin):
+@admin.register(MagazineIssue)
+class MagazineIssueAdmin(SortableAdminBase, admin.ModelAdmin):
     inlines = (
         BookPropertyInline,
         BookImageInline,
@@ -368,10 +375,8 @@ class MagazineIssueAdmin(admin.ModelAdmin):
         "issue_number",
         "published",
     )
-    # autocomplete_fields = ("publisher",)
-    # readonly_fields = ("creation_time", "updated_time")
-    # search_fields = ("title", "publisher__name")
-    # list_filter = ("publisher__name", "language")
+    autocomplete_fields = ("shop",)
+    readonly_fields = ("magazine", "creation_time", "updated_time")
 
     def get_model_perms(self, request):
         """
@@ -379,14 +384,80 @@ class MagazineIssueAdmin(admin.ModelAdmin):
         """
         return {}
 
+    fieldsets = (
+        (
+            None,
+            {
+                "fields": (
+                    "published",
+                    "magazine",
+                    "issue_number",
+                    "publication_year",
+                    "publication_month",
+                    "ISBN",
+                    "language",
+                    "number_of_pages",
+                    "description",
+                    "tags",
+                )
+            },
+        ),
+        (
+            "Purchase data",
+            {
+                "classes": ("collapse",),
+                "fields": (
+                    "shop",
+                    "purchase_date",
+                    "price",
+                ),
+            },
+        ),
+        (
+            "Notes",
+            {"classes": ("collapse",), "fields": ("notes",)},
+        ),
+        (
+            "Audit",
+            {
+                "classes": ("collapse",),
+                "fields": (
+                    "creation_time",
+                    "updated_time",
+                ),
+            },
+        ),
+    )
     actions = [publish, unpublish]
 
 
+class MagazineIssueInline(admin.TabularInline):
+    model = MagazineIssue
+    min_num = 0
+    extra = 0
+    autocomplete_fields = ("shop",)
+    show_change_link = True
+    fields = (
+        "preview",
+        "published",
+        "issue_number",
+        "publication_year",
+        "publication_month",
+        "number_of_pages",
+        "language",
+    )
+    readonly_fields = ("preview",)
+
+    class Media:
+        js = ('admin/js/magazine_issue_defaults.js',)
+
+
 @admin.register(Magazine)
-class MagazineAdmin(admin.ModelAdmin):
+class MagazineAdmin(SortableAdminBase, admin.ModelAdmin):
     inlines = (
         MagazineIssueInline,
     )
+
     list_display = (
         "__str__",
         "publisher",
@@ -395,6 +466,37 @@ class MagazineAdmin(admin.ModelAdmin):
     autocomplete_fields = ("publisher",)
     readonly_fields = ("creation_time", "updated_time")
     search_fields = ("name", "publisher__name")
-    list_filter = ("publisher__name", "language")
+    list_filter = ("publisher__name", "published")
 
+    fieldsets = (
+        (
+            None,
+            {
+                "fields": (
+                    "published",
+                    "name",
+                    "publisher",
+                    "ISBN",
+                    "language",
+                    "description",
+                    "image",
+                    "tags",
+                )
+            },
+        ),
+        (
+            "Notes",
+            {"classes": ("collapse",), "fields": ("notes",)},
+        ),
+        (
+            "Audit",
+            {
+                "classes": ("collapse",),
+                "fields": (
+                    "creation_time",
+                    "updated_time",
+                ),
+            },
+        ),
+    )
     actions = [publish, unpublish]

ram/bookshelf/migrations/0016_basebook_book_catalogue.py

@@ -1,7 +1,8 @@
 # Generated by Django 5.1.2 on 2024-11-27 16:35
 
 import django.db.models.deletion
-from django.db import migrations, models
+from django.db import migrations, models, connection
+from django.db.utils import ProgrammingError, OperationalError
 
 
 def basebook_to_book(apps, schema_editor):
@@ -16,6 +17,19 @@ def basebook_to_book(apps, schema_editor):
         b.authors.set(row.old_authors.all())
 
 
+def drop_temporary_tables(apps, schema_editor):
+    try:
+        with connection.cursor() as cursor:
+            cursor.execute(
+                'DROP TABLE IF EXISTS bookshelf_basebook_old_authors'
+            )
+            cursor.execute(
+                'DROP TABLE IF EXISTS bookshelf_basebook_authors'
+            )
+    except (ProgrammingError, OperationalError):
+        pass
+
+
 class Migration(migrations.Migration):
 
     dependencies = [
@@ -101,10 +115,6 @@ class Migration(migrations.Migration):
             model_name="basebook",
             name="old_title",
         ),
-        migrations.RemoveField(
-            model_name="basebook",
-            name="old_authors",
-        ),
         migrations.RemoveField(
             model_name="basebook",
             name="old_publisher",
@@ -138,4 +148,16 @@ class Migration(migrations.Migration):
             },
             bases=("bookshelf.basebook",),
         ),
+        # Required by Dajngo 6.0 on SQLite
+        migrations.SeparateDatabaseAndState(
+            state_operations=[
+                migrations.RemoveField(
+                    model_name="basebook",
+                    name="old_authors",
+                ),
+            ],
+            database_operations=[
+                migrations.RunPython(drop_temporary_tables)
+            ]
+        ),
     ]

ram/bookshelf/migrations/0024_alter_basebook_language.py

@@ -0,0 +1,123 @@
+# Generated by Django 6.0 on 2025-12-03 22:07
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("bookshelf", "0023_delete_basebookdocument"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="basebook",
+            name="language",
+            field=models.CharField(
+                choices=[
+                    ("af", "Afrikaans"),
+                    ("ar", "Arabic"),
+                    ("ar-dz", "Algerian Arabic"),
+                    ("ast", "Asturian"),
+                    ("az", "Azerbaijani"),
+                    ("bg", "Bulgarian"),
+                    ("be", "Belarusian"),
+                    ("bn", "Bengali"),
+                    ("br", "Breton"),
+                    ("bs", "Bosnian"),
+                    ("ca", "Catalan"),
+                    ("ckb", "Central Kurdish (Sorani)"),
+                    ("cs", "Czech"),
+                    ("cy", "Welsh"),
+                    ("da", "Danish"),
+                    ("de", "German"),
+                    ("dsb", "Lower Sorbian"),
+                    ("el", "Greek"),
+                    ("en", "English"),
+                    ("en-au", "Australian English"),
+                    ("en-gb", "British English"),
+                    ("eo", "Esperanto"),
+                    ("es", "Spanish"),
+                    ("es-ar", "Argentinian Spanish"),
+                    ("es-co", "Colombian Spanish"),
+                    ("es-mx", "Mexican Spanish"),
+                    ("es-ni", "Nicaraguan Spanish"),
+                    ("es-ve", "Venezuelan Spanish"),
+                    ("et", "Estonian"),
+                    ("eu", "Basque"),
+                    ("fa", "Persian"),
+                    ("fi", "Finnish"),
+                    ("fr", "French"),
+                    ("fy", "Frisian"),
+                    ("ga", "Irish"),
+                    ("gd", "Scottish Gaelic"),
+                    ("gl", "Galician"),
+                    ("he", "Hebrew"),
+                    ("hi", "Hindi"),
+                    ("hr", "Croatian"),
+                    ("hsb", "Upper Sorbian"),
+                    ("ht", "Haitian Creole"),
+                    ("hu", "Hungarian"),
+                    ("hy", "Armenian"),
+                    ("ia", "Interlingua"),
+                    ("id", "Indonesian"),
+                    ("ig", "Igbo"),
+                    ("io", "Ido"),
+                    ("is", "Icelandic"),
+                    ("it", "Italian"),
+                    ("ja", "Japanese"),
+                    ("ka", "Georgian"),
+                    ("kab", "Kabyle"),
+                    ("kk", "Kazakh"),
+                    ("km", "Khmer"),
+                    ("kn", "Kannada"),
+                    ("ko", "Korean"),
+                    ("ky", "Kyrgyz"),
+                    ("lb", "Luxembourgish"),
+                    ("lt", "Lithuanian"),
+                    ("lv", "Latvian"),
+                    ("mk", "Macedonian"),
+                    ("ml", "Malayalam"),
+                    ("mn", "Mongolian"),
+                    ("mr", "Marathi"),
+                    ("ms", "Malay"),
+                    ("my", "Burmese"),
+                    ("nb", "Norwegian Bokmål"),
+                    ("ne", "Nepali"),
+                    ("nl", "Dutch"),
+                    ("nn", "Norwegian Nynorsk"),
+                    ("os", "Ossetic"),
+                    ("pa", "Punjabi"),
+                    ("pl", "Polish"),
+                    ("pt", "Portuguese"),
+                    ("pt-br", "Brazilian Portuguese"),
+                    ("ro", "Romanian"),
+                    ("ru", "Russian"),
+                    ("sk", "Slovak"),
+                    ("sl", "Slovenian"),
+                    ("sq", "Albanian"),
+                    ("sr", "Serbian"),
+                    ("sr-latn", "Serbian Latin"),
+                    ("sv", "Swedish"),
+                    ("sw", "Swahili"),
+                    ("ta", "Tamil"),
+                    ("te", "Telugu"),
+                    ("tg", "Tajik"),
+                    ("th", "Thai"),
+                    ("tk", "Turkmen"),
+                    ("tr", "Turkish"),
+                    ("tt", "Tatar"),
+                    ("udm", "Udmurt"),
+                    ("ug", "Uyghur"),
+                    ("uk", "Ukrainian"),
+                    ("ur", "Urdu"),
+                    ("uz", "Uzbek"),
+                    ("vi", "Vietnamese"),
+                    ("zh-hans", "Simplified Chinese"),
+                    ("zh-hant", "Traditional Chinese"),
+                ],
+                default="en",
+                max_length=7,
+            ),
+        ),
+    ]

ram/bookshelf/migrations/0025_magazine_magazineissue.py

@@ -1,4 +1,4 @@
-# Generated by Django 5.2.8 on 2025-11-13 23:01
+# Generated by Django 6.0 on 2025-12-08 17:47
 
 import bookshelf.models
 import django.db.models.deletion
@@ -11,32 +11,11 @@ from django.db import migrations, models
 class Migration(migrations.Migration):
 
     dependencies = [
-        ("bookshelf", "0023_delete_basebookdocument"),
+        ("bookshelf", "0024_alter_basebook_language"),
         ("metadata", "0025_alter_company_options_alter_manufacturer_options_and_more"),
     ]
 
     operations = [
-        migrations.CreateModel(
-            name="Issue",
-            fields=[
-                (
-                    "basebook_ptr",
-                    models.OneToOneField(
-                        auto_created=True,
-                        on_delete=django.db.models.deletion.CASCADE,
-                        parent_link=True,
-                        primary_key=True,
-                        serialize=False,
-                        to="bookshelf.basebook",
-                    ),
-                ),
-                ("issue_number", models.CharField(max_length=100)),
-            ],
-            options={
-                "abstract": False,
-            },
-            bases=("bookshelf.basebook",),
-        ),
         migrations.CreateModel(
             name="Magazine",
             fields=[
@@ -55,12 +34,13 @@ class Migration(migrations.Migration):
                 ("updated_time", models.DateTimeField(auto_now=True)),
                 ("published", models.BooleanField(default=True)),
                 ("name", models.CharField(max_length=200)),
+                ("ISBN", models.CharField(blank=True, max_length=17)),
                 (
                     "image",
                     models.ImageField(
                         blank=True,
                         storage=ram.utils.DeduplicatedStorage,
-                        upload_to=bookshelf.models.magazine_image_upload,
+                        upload_to=bookshelf.models.book_image_upload,
                     ),
                 ),
                 (
@@ -108,6 +88,7 @@ class Migration(migrations.Migration):
                             ("hi", "Hindi"),
                             ("hr", "Croatian"),
                             ("hsb", "Upper Sorbian"),
+                            ("ht", "Haitian Creole"),
                             ("hu", "Hungarian"),
                             ("hy", "Armenian"),
                             ("ia", "Interlingua"),
@@ -193,34 +174,51 @@ class Migration(migrations.Migration):
             name="MagazineIssue",
             fields=[
                 (
-                    "id",
-                    models.BigAutoField(
+                    "basebook_ptr",
+                    models.OneToOneField(
                         auto_created=True,
+                        on_delete=django.db.models.deletion.CASCADE,
+                        parent_link=True,
                         primary_key=True,
                         serialize=False,
-                        verbose_name="ID",
+                        to="bookshelf.basebook",
                     ),
                 ),
+                ("issue_number", models.CharField(max_length=100)),
                 (
-                    "issue",
-                    models.ForeignKey(
-                        on_delete=django.db.models.deletion.CASCADE,
-                        related_name="magazine_issue",
-                        to="bookshelf.issue",
+                    "publication_month",
+                    models.SmallIntegerField(
+                        blank=True,
+                        choices=[
+                            (1, "January"),
+                            (2, "February"),
+                            (3, "March"),
+                            (4, "April"),
+                            (5, "May"),
+                            (6, "June"),
+                            (7, "July"),
+                            (8, "August"),
+                            (9, "September"),
+                            (10, "October"),
+                            (11, "November"),
+                            (12, "December"),
+                        ],
+                        null=True,
                     ),
                 ),
                 (
                     "magazine",
                     models.ForeignKey(
                         on_delete=django.db.models.deletion.CASCADE,
-                        related_name="magazine_issue",
+                        related_name="issue",
                         to="bookshelf.magazine",
                     ),
                 ),
             ],
             options={
-                "ordering": ["magazine", "issue"],
-                "unique_together": {("magazine", "issue")},
+                "ordering": ["magazine", "issue_number"],
+                "unique_together": {("magazine", "issue_number")},
             },
+            bases=("bookshelf.basebook",),
         ),
     ]

ram/bookshelf/models.py

@@ -4,6 +4,7 @@ from django.db import models
 from django.conf import settings
 from django.urls import reverse
 from django.utils.dates import MONTHS
+from django.core.exceptions import ValidationError
 from django_countries.fields import CountryField
 
 from ram.utils import DeduplicatedStorage
@@ -212,4 +213,14 @@ class MagazineIssue(BaseBook):
         ordering = ["magazine", "issue_number"]
 
     def __str__(self):
-        return f"{self.magazine.name} - {self.issue.issue_number}"
+        return f"{self.magazine.name} - {self.issue_number}"
+
+    def clean(self):
+        if self.magazine.published is False and self.published is True:
+            raise ValidationError(
+                "Cannot set an issue as published if the magazine is not "
+                "published."
+            )
+
+    def preview(self):
+        return self.image.first().image_thumbnail(100)

ram/bookshelf/static/admin/js/magazine_issue_defaults.js

@@ -0,0 +1,16 @@
+document.addEventListener('formset:added', function(event) {
+  const newForm = event.target; // the new inline form element
+
+  const defaultLanguage = document.querySelector('#id_language').value;
+  const defaultStatus = document.querySelector('#id_published').checked;
+
+  const languageInput = newForm.querySelector('select[name$="language"]');
+  const statusInput = newForm.querySelector('input[name$="published"]');
+
+  if (languageInput) {
+      languageInput.value = defaultLanguage;
+  }
+  if (statusInput) {
+    statusInput.checked = defaultStatus;
+  }
+});

ram/consist/admin.py

@@ -54,7 +54,7 @@ class ConsistAdmin(SortableAdminBase, admin.ModelAdmin):
     @admin.display(description="Country")
     def country_flag(self, obj):
         return format_html(
-            '<img src="{}" /> {}'.format(obj.country.flag, obj.country)
+            '<img src="{}" /> {}', obj.country.flag, obj.country
         )
 
     fieldsets = (

ram/metadata/admin.py

@@ -54,7 +54,7 @@ class CompanyAdmin(admin.ModelAdmin):
     @admin.display(description="Country")
     def country_flag(self, obj):
         return format_html(
-            '<img src="{}" /> {}'.format(obj.country.flag, obj.country.name)
+            '<img src="{}" /> {}', obj.country.flag, obj.country.name
         )
 
 
@@ -68,7 +68,7 @@ class ManufacturerAdmin(admin.ModelAdmin):
     @admin.display(description="Country")
     def country_flag(self, obj):
         return format_html(
-            '<img src="{}" /> {}'.format(obj.country.flag, obj.country.name)
+            '<img src="{}" /> {}', obj.country.flag, obj.country.name
         )
 
 

ram/portal/templates/includes/login.html

@@ -11,9 +11,10 @@
             <ul class="dropdown-menu" aria-labelledby="dropdownLogin">
               <li><a class="dropdown-item" href="{% url 'admin:roster_rollingstock_changelist' %}">Rolling stock</a></li>
               <li><a class="dropdown-item" href="{% url 'admin:consist_consist_changelist' %}">Consists</a></li>
-              <li><a class="dropdown-item" href="{% url 'admin:app_list' 'metadata' %}">Metadata</a></li>
-              <li><a class="dropdown-item" href="{% url 'admin:portal_flatpage_changelist' %}">Pages</a></li>
               <li><a class="dropdown-item" href="{% url 'admin:app_list' 'bookshelf' %}">Bookshelf</a></li>
+              <li><a class="dropdown-item" href="{% url 'admin:portal_flatpage_changelist' %}">Pages</a></li>
+              <li><a class="dropdown-item" href="{% url 'admin:app_list' 'repository' %}">Repository</a></li>
+              <li><a class="dropdown-item" href="{% url 'admin:app_list' 'metadata' %}">Metadata</a></li>
               <li><hr class="dropdown-divider"></li>
               <li><a class="dropdown-item" href="{% url 'admin:index' %}">Admin</a></li>
               <li><a class="dropdown-item" href="{% url 'admin:portal_siteconfiguration_changelist' %}">Site configuration</a></li>

ram/portal/templatetags/dcc.py

@@ -1,36 +1,38 @@
 from django import template
 from django.utils.html import format_html
+from django.utils.safestring import mark_safe
 
 register = template.Library()
 
 
 @register.simple_tag
 def dcc(object):
-    socket = (
+    socket = mark_safe(
         '<i class="bi bi-ban small"></i>'
     )
     decoder = ''
     if object.decoder_interface is not None:
-        socket = (
+        socket = mark_safe(
             f'<abbr title="{object.get_decoder_interface()}">'
             f'<i class="bi bi-dice-6"></i></abbr>'
         )
     if object.decoder:
         if object.decoder.sound:
-            decoder = (
+            decoder = mark_safe(
                 f'<abbr title="{object.decoder}">'
                 '<i class="bi bi-volume-up-fill"></i></abbr>'
             )
         else:
-            decoder = (
+            decoder = mark_safe(
                 f'<abbr title="{object.decoder}'
                 f'({object.get_decoder_interface()})">'
                 '<i class="bi bi-cpu-fill"></i></abbr>'
             )
-
     if decoder:
         return format_html(
-            f'{socket} <i class="bi bi-arrow-bar-left"></i>{decoder}'
+            '{} <i class="bi bi-arrow-bar-left"></i> {}',
+            socket,
+            decoder,
         )
 
-    return format_html(socket)
+    return socket

ram/ram/__init__.py

@@ -1,4 +1,4 @@
 from ram.utils import git_suffix
 
-__version__ = "0.17.14"
+__version__ = "0.18.00"
 __version__ += git_suffix(__file__)

ram/ram/settings.py

@@ -150,7 +150,7 @@ REST_FRAMEWORK = {
 }
 
 TINYMCE_DEFAULT_CONFIG = {
-    "height": "500px",
+    "height": "300px",
     "menubar": False,
     "plugins": "autolink lists link image charmap preview anchor "
     "searchreplace visualblocks code fullscreen insertdatetime media "

ram/ram/utils.py

@@ -48,8 +48,9 @@ def git_suffix(fname):
 
 def get_image_preview(url, max_size=150):
     return format_html(
-        '<img src="{src}" style="max-width: {size}px; max-height: {size}px;'
-        'background-color: #eee;" />'.format(src=url, size=max_size)
+        '<img src="{src}" style="max-width: {size}px; max-height: {size}px; background-color: #eee;" />',  # noqa: E501
+        src=url,
+        size=max_size,
     )
 
 

ram/repository/migrations/0004_magazineissuedocument.py

@@ -0,0 +1,65 @@
+# Generated by Django 6.0 on 2025-12-08 17:47
+
+import django.db.models.deletion
+import ram.utils
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("bookshelf", "0025_magazine_magazineissue"),
+        (
+            "repository",
+            "0003_alter_bookdocument_file_alter_catalogdocument_file_and_more",
+        ),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name="MagazineIssueDocument",
+            fields=[
+                (
+                    "id",
+                    models.BigAutoField(
+                        auto_created=True,
+                        primary_key=True,
+                        serialize=False,
+                        verbose_name="ID",
+                    ),
+                ),
+                ("description", models.CharField(blank=True, max_length=128)),
+                (
+                    "file",
+                    models.FileField(
+                        storage=ram.utils.DeduplicatedStorage, upload_to="files/"
+                    ),
+                ),
+                ("creation_time", models.DateTimeField(auto_now_add=True)),
+                ("updated_time", models.DateTimeField(auto_now=True)),
+                (
+                    "private",
+                    models.BooleanField(
+                        default=False,
+                        help_text="Document will be visible only to logged users",
+                    ),
+                ),
+                (
+                    "issue",
+                    models.ForeignKey(
+                        on_delete=django.db.models.deletion.CASCADE,
+                        related_name="document",
+                        to="bookshelf.magazineissue",
+                    ),
+                ),
+            ],
+            options={
+                "verbose_name_plural": "Magazines documents",
+                "constraints": [
+                    models.UniqueConstraint(
+                        fields=("issue", "file"), name="unique_issue_file"
+                    )
+                ],
+            },
+        ),
+    ]

ram/repository/models.py

@@ -5,7 +5,7 @@ from tinymce import models as tinymce
 from ram.models import PrivateDocument
 from metadata.models import Decoder, Shop, Tag
 from roster.models import RollingStock
-from bookshelf.models import Book, Catalog, Issue
+from bookshelf.models import Book, Catalog, MagazineIssue
 
 
 class GenericDocument(PrivateDocument):
@@ -78,7 +78,7 @@ class CatalogDocument(PrivateDocument):
 
 class MagazineIssueDocument(PrivateDocument):
     issue = models.ForeignKey(
-        Issue, on_delete=models.CASCADE, related_name="document"
+        MagazineIssue, on_delete=models.CASCADE, related_name="document"
     )
 
     class Meta:

ram/roster/admin.py

@@ -2,7 +2,7 @@ import html
 
 from django.conf import settings
 from django.contrib import admin
-from django.utils.html import format_html, strip_tags
+from django.utils.html import format_html, format_html_join, strip_tags
 
 from adminsortable2.admin import SortableAdminBase, SortableInlineAdminMixin
 
@@ -44,7 +44,7 @@ class RollingClass(admin.ModelAdmin):
     @admin.display(description="Country")
     def country_flag(self, obj):
         return format_html(
-            '<img src="{}" /> {}'.format(obj.country.flag, obj.country)
+            '<img src="{}" /> {}', obj.country.flag, obj.country.name
         )
 
 
@@ -152,7 +152,7 @@ class RollingStockAdmin(SortableAdminBase, admin.ModelAdmin):
     @admin.display(description="Country")
     def country_flag(self, obj):
         return format_html(
-            '<img src="{}" /> {}'.format(obj.country.flag, obj.country)
+            '<img src="{}" /> {}', obj.country.flag, obj.country.name
         )
 
     fieldsets = (
@@ -222,13 +222,14 @@ class RollingStockAdmin(SortableAdminBase, admin.ModelAdmin):
     @admin.display(description="Invoices")
     def invoices(self, obj):
         if obj.invoice.exists():
-            html = "<br>".join(
-                "<a href=\"{}\" target=\"_blank\">{}</a>".format(
-                    i.file.url, i
-                ) for i in obj.invoice.all())
+            html = format_html_join(
+                "<br>",
+                "<a href=\"{}\" target=\"_blank\">{}</a>",
+                ((i.file.url, i) for i in obj.invoice.all())
+            )
         else:
             html = "-"
-        return format_html(html)
+        return html
 
     def download_csv(modeladmin, request, queryset):
         header = [